Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][2.10][PR #70445] Fix the internal Python API usage examples #70841

Merged
merged 1 commit into from Jul 23, 2020

Conversation

webknjaz
Copy link
Member

SUMMARY

Backport of 8d97c8c.

The previous version initialized the TaskQueueManager after calling
Play.load() while advertising a way to inject a custom library
location path. This caused the tasks loader not to find any custom
modules because it was triggered before the path was actually added
to the module loader.

This patch changes the order of the operations to ensure that the
customized context.CLIARGS actually influences things.

Resolves #69758.

ISSUE TYPE
  • Docs Pull Request Backport
COMPONENT NAME

Internal Python API usage examples.

ADDITIONAL INFORMATION

N/A

Previous version initialized the `TaskQueueManager` after calling
`Play.load()` while advertising a way to inject a custom library
location path. This caused the tasks loader not to find any custom
modules because it was triggered before the path was actually added
to the module loader.

This patch changes the order of the operations to ensure that the
customized `context.CLIARGS` actually influences things.

Resolves ansible#69758.

(cherry picked from commit 8d97c8c)
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 23, 2020
@nitzmahone nitzmahone merged commit 7969b60 into ansible:stable-2.10 Jul 23, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2020
@ansible ansible locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants